feat(settings): implement IDelegatedSettings for activity admin settings - #2885
Open
printminion-co wants to merge 1 commit into
Open
Conversation
Signed-off-by: Kai Henseler <[email protected]>
This was referenced Aug 28, 2026
artonge
reviewed
Sep 1, 2026
|
|
||
| #[\Override] | ||
| public function getAuthorizedAppConfig(): array { | ||
| return []; |
Collaborator
There was a problem hiding this comment.
Shouldn't this contain a list of app config?
Looks like at least enable_email would be needed, the others seems to be set through a custom endpoint.
Can you double-check?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
IDelegatedSettingsfor the activity admin settings page (OCA\Activity\Settings\Admin), instead of the plainISettingsinterface. This allows an administrator to delegate management of the activity settings to a non-admin user or group via the admin delegation feature, without granting full admin rights.getName()returns the translated section label,Activity.getAuthorizedAppConfig()returns[]— no app config keys are exposed for direct delegated editing beyond the settings form itself.IL10Nis already injected in this class, so the change is additive only.#[\Override]is set on both new methods, matching the rest of the class.Companion to nextcloud/bruteforcesettings#1246, which makes the same change for the brute-force IP allowlist settings.
AI disclosure
This change was prepared with AI assistance (Claude Code): the cherry-pick and rebase mechanics onto current
master, the#[\Override]consistency fix, and this PR description. The underlying code change and the DCO sign-off are from a human contributor.Testing
composer lint— cleancomposer cs:check— clean, 0 of 98 files need fixingcomposer psalmwas not run locally: the pinned Psalm 7.0.0-beta19 requires PHP >= 8.3.16 and the available container has PHP 8.3.6. CI covers it here.